[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336155: [lldb-mi] Re-implement a few MI commands. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48520?vs=152715&id=1

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

clayborg added a comment. Just waiting for Adrian to indicate he is happy with testing stuff. LGTM https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added a comment. Update comment. It still needs a review, thanks for your time. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:228 -# Test that --thread is optional -self.runCmd("-exec-next-instruction --frame 0") -self.expect("\^running") aprantl wrote

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:228 -# Test that --thread is optional -self.runCmd("-exec-next-instruction --frame 0") -self.expect("\^running") Is this combina

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov updated this revision to Diff 152715. apolyakov added a comment. Removed duplicated and error prone(without --synchronous option) testing. https://reviews.llvm.org/D48520 Files: lit/tools/lldb-mi/exec/exec-finish.test lit/tools/lldb-mi/exec/exec-interrupt.test lit/tools/lldb-mi/

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

clayborg added a comment. LGTM. Ok when Adrian is happy with testing changes. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added a comment. You are right about python tests. Let's remove them. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

aprantl added a comment. Nice. Since you are adding new lit-based tests for these commands, does that mean that the old python tests become redundant and could we remove them? IIRC the python tests don't set synchronous mode so they are prone to fail under load. https://reviews.llvm.org/D4852

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added a comment. [WIP] Fully test `-exec-interrupt` command. It needs a program being executed at the moment of debugging to stop it. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.l

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg. Herald added a subscriber: ki.stfu. This patch updates exec-next-instruction, exec-step-instruction, exec-finish, exec-interrupt commands to use SB API instead of HandleCommand. https://reviews.llvm.org/D48520 Files