This revision was automatically updated to reflect the committed changes.
Closed by commit rL335271: [DataFormatter] Add CFDictionary data formatter
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48450?vs=152354&id=152359#toc
Repository:
rL LLVM
jingham added subscribers: JDevlieghere, jingham.
jingham added a comment.
Yes, I really wish unittest2 allowed non-aborting tests. If you split up all
these tests, then you make the testsuite have to build and run some little
executable over and over. It would be so nice if there were a way t
Yes, I really wish unittest2 allowed non-aborting tests. If you split up all
these tests, then you make the testsuite have to build and run some little
executable over and over. It would be so nice if there were a way to say:
self.startTestBundle()
self.assertTrue(something)
...
self.
JDevlieghere updated this revision to Diff 152354.
JDevlieghere added a comment.
- Also test CFDictionaryRef
https://reviews.llvm.org/D48450
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py
packages/Python/lldbsuite/test/fun
clayborg added a comment.
It might be nice to split up the tests a bit. The data formatter tests have a
history of testing 1000 things at once and saying "something failed in the this
test with 1000 things". It would be nice if we knew that only dictionaries were
failing by testing each type in
davide added a comment.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D48450
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D48450
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
