This revision was automatically updated to reflect the committed changes.
Closed by commit rL335104: Remove dependency from Host to python (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48215
Files:
lldb/trunk/incl
labath updated this revision to Diff 151922.
labath added a comment.
Rebase this patch on trunk. Now this patch is simply about moving GetPythonDir
from Host module to ScriptInterpreterPython.
https://reviews.llvm.org/D48215
Files:
include/lldb/Host/macosx/HostInfoMacOSX.h
include/lldb/Host
labath planned changes to this revision.
labath added a comment.
Ok, I'll start with the other patch first.
https://reviews.llvm.org/D48215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
clayborg added a comment.
In https://reviews.llvm.org/D48215#1133725, @labath wrote:
> (pressed return too soon)
>
> Would that address your reservations about this idea?
yeah, just don't like the idea of HostInfo::GetLLDBPath() being non functional.
https://reviews.llvm.org/D48215
___
clayborg added a comment.
It might be nice to start with the removal of HostInfo::GetLLDBPath(...) first
and fixing up all call sites that use that API to use the new internally
sanctioned versions. Then submit this patch?
https://reviews.llvm.org/D48215
labath added a comment.
(pressed return too soon)
Would that address your reservations about this idea?
https://reviews.llvm.org/D48215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
labath added a comment.
Actually, my plan was to follow this up with a patch which removes usages of
that enumeration from the internal api altogether (basically do a
`s/GetLLDBPath(ePathTypeXXX/GetXXXPath`). That should make the internal api
nicer, and provide a clean separation between the in
zturner added a comment.
It can assert when we pass the python or clang directory enumeration. We
could also remove the values from the internal enumeration but keep them in
the public enumeration. However, we can’t be forced into providing a stable
internal api just because we must provide a stab
It can assert when we pass the python or clang directory enumeration. We
could also remove the values from the internal enumeration but keep them in
the public enumeration. However, we can’t be forced into providing a stable
internal api just because we must provide a stable public api.
On Fri, Jun
clayborg added a comment.
In https://reviews.llvm.org/D48215#1133695, @zturner wrote:
> The internal api has no guarantees as to its stability.
What do you mean by this? If we have an internal API that claims to give out
paths, it should give out paths. What am I missing here?
https://review
zturner added a subscriber: labath.
zturner added a comment.
The internal api has no guarantees as to its stability.
https://reviews.llvm.org/D48215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
The internal api has no guarantees as to its stability.
On Fri, Jun 15, 2018 at 7:48 AM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added inline comments.
>
>
>
> Comment at: source/API/SBHostOS.cpp:48
> + case ePathTypePythonDir:
> +fspec = Scr
clayborg added inline comments.
Comment at: source/API/SBHostOS.cpp:48
+ case ePathTypePythonDir:
+fspec = ScriptInterpreterPython::GetPythonDir();
+break;
Why is this here instead of inside of "HostInfo::GetLLDBPath(path_type,
fspec);"? Does this mean
labath created this revision.
labath added reviewers: zturner, jingham, davide.
Herald added a subscriber: mgorny.
The only reason python was used in the Host module was to compute the
python path. I resolve this the same way as https://reviews.llvm.org/D47384 did
for clang, moving
the path compu
14 matches
Mail list logo
