This revision was automatically updated to reflect the committed changes.
Closed by commit rL334638: [ObjC] Add dataformatter for NSDecimalNumber
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48114?vs=151096&id=151217#toc
Repository:
rL LLVM
h
jingham accepted this revision.
jingham added a comment.
This looks fine to me. Nothing in the TypeSummaryOptions is relevant to
printing these numbers, so it's correct to ignore them.
Repository:
rL LLVM
https://reviews.llvm.org/D48114
___
lld
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I didn't check whether the representation was correct (although it looks lo).
The structure of the patch looks fine to me, thanks for adding the comments :)
Repository:
rL LLVM
https://rev
aprantl added inline comments.
Comment at: source/Plugins/Language/ObjC/Cocoa.cpp:462
+ if (!strcmp(class_name, "NSDecimalNumber"))
+return NSDecimalNumberSummaryProvider(valobj, stream, options);
Side note: It would be slightly faster/elegant to use a Str
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, jingham, jasonmolenda.
This patch adds a data formatter for NSDecimalNumber. The latter is a
Foundation object used for representing and performing arithmetic on base-10
numbers that bridges to Decimal.
Repository:
rL
