[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor planned changes to this revision. teemperor added a comment. It seems the compilation fails on OS X with this modulemap (or any modulemap). The reason seems to be that on OS X we compile Obj-C++ as part of lldb which assumes that Clang/LLVM is valid Obj-C++. However, the Obj-C parsing

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor updated this revision to Diff 150604. teemperor added a comment. - Removed some inconsistent white space. https://reviews.llvm.org/D47929 Files: include/lldb/module.modulemap Index: include/lldb/module.modulemap === --

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. @aprantl It's good for build times and more importantly it's consistent with the way Clang/LLVM are naming/organizing their modules. But I actually don't have a strong opinion on how the modules are named/organized. @bruno Breaking up the lldb module in the future is

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

bruno added a comment. Very nice! > I generated a report for the remaining cyclic dependencies in the `lldb` > module here . Do you plan to fix headers at some point to break out the dependencies? Comment at: incl

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

aprantl added a comment. That's awesome! May I ask why you chose to use lldb_Component modules instead of doing submodules? Is this for build performance? https://reviews.llvm.org/D47929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor added a comment. I generated a report for the remaining cyclic dependencies in the `lldb` module here . Note that I'll provide a modulemap for the `source/` headers in another patch, so this is out of scope for this review.

[Lldb-commits] [PATCH] D47929: Add modulemap to lldb include directory

teemperor created this revision. teemperor added a reviewer: aprantl. This patch adds a modulemap which allows compiling the lldb headers into C++ modules (for example in builds with LLVM_ENABLE_MODULES=On). Even though most of the affected code has been cleaned up to work with the more strict