[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

2018-06-07 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL334219: Check for process_vm_readv using CheckSymbolExists (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47897 Files: l

[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

2018-06-07 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This should be functionally identical and is much cleaner. Thanks! https://reviews.llvm.org/D47897 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D47897: Check for process_vm_readv using CheckSymbolExists

2018-06-07 Thread Alex Langford via Phabricator via lldb-commits
xiaobai created this revision. xiaobai added reviewers: eugene, labath, beanz. Herald added a subscriber: mgorny. Instead of checking if code compiles, I think it is a better to check if the symbol exists. This is simpler and should do the same thing. https://reviews.llvm.org/D47897 Files: cm