This revision was automatically updated to reflect the committed changes.
Closed by commit rL04: Move SystemInitializerFull header to source/API
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47342?vs=148459&
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Fine by me.
https://reviews.llvm.org/D47342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
clayborg added a comment.
Looks good to me. Pavel, you ok with the file location?
https://reviews.llvm.org/D47342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xiaobai created this revision.
xiaobai added reviewers: labath, clayborg.
It seems to me that files in include/lldb/API/ are headers that should
be exposed to liblldb users. Because SystemInitializerFull.h exposes details of
lldb_private, I think having it there is not the right thing to do. Since