[Lldb-commits] [PATCH] D47342: Move SystemInitializerFull header to source/API

2018-05-25 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL04: Move SystemInitializerFull header to source/API (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47342?vs=148459&

[Lldb-commits] [PATCH] D47342: Move SystemInitializerFull header to source/API

2018-05-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Fine by me. https://reviews.llvm.org/D47342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D47342: Move SystemInitializerFull header to source/API

2018-05-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Looks good to me. Pavel, you ok with the file location? https://reviews.llvm.org/D47342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47342: Move SystemInitializerFull header to source/API

2018-05-24 Thread Alex Langford via Phabricator via lldb-commits
xiaobai created this revision. xiaobai added reviewers: labath, clayborg. It seems to me that files in include/lldb/API/ are headers that should be exposed to liblldb users. Because SystemInitializerFull.h exposes details of lldb_private, I think having it there is not the right thing to do. Since