[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

2018-05-21 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL332831: Add some apple-tables lookup tests (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47064 Files: lldb/trunk/lit/Sym

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

2018-05-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17 // RUN: FileCheck --check-prefix=EMPTY %s +// +// RUN: clang %s -g -c -o %t --target=x86_64-apple-macosx JDevlieghere wrote: > `%t.o`? I prefer %t, as that makes the RUN

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

2018-05-18 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17 // RUN: FileCheck --check-prefix=EMPTY %s +// +// RUN: clang %s -g -c -o %t --target=x86_64-a

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

2018-05-18 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added subscribers: ioeric, ilya-biryukov, aprantl. Now that we are able to parse MachO files everywhere, we can write some cross-platform tests for handling of apple accelerator tables. This reruns the same lookup