This revision was automatically updated to reflect the committed changes.
Closed by commit rL332250: Remove Process references from the Host module
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46395
Files:
lldb/t
labath updated this revision to Diff 145163.
labath marked an inline comment as done.
labath added a comment.
Update the diff.
https://reviews.llvm.org/D46395
Files:
include/lldb/Host/Host.h
include/lldb/Host/MonitoringProcessLauncher.h
include/lldb/Target/ProcessLaunchInfo.h
source/Hos
labath marked an inline comment as done.
labath added a comment.
I've added a comment about the requirement to the `MonitoringProcessLauncher`
and to `Host::LaunchProcess` (most users go through the latter). I've also
tried to make it more obvious that the no-op callback still causes the process
clayborg added inline comments.
Comment at: source/Host/macosx/Host.mm:1501
+bool monitoring = launch_info.MonitorProcess();
+(void)monitoring;
+assert(monitoring);
Do we not have a macro for silencing unused variables?
Comment at:
davide accepted this revision.
davide added a comment.
lg
https://reviews.llvm.org/D46395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This is a cleaner approach. Might be worth adding a comment in the
MonitoringProcessLauncher.h saying that the monitoring callback in the
ProcessLaunchInfo is required? You might from the
labath created this revision.
labath added reviewers: jingham, davide.
Herald added a subscriber: emaste.
The Process class was only being referenced because of the last-ditch
effort in the process launchers to set a process exit callback in case
one isn't set already.
Although launching a proces
