[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

2018-05-01 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

2018-05-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

2018-05-01 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: test/CMakeLists.txt:138 if(CMAKE_HOST_APPLE) - list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH}) + if (DEBUGSERVER_PATH STREQUAL "$") +list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

2018-05-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: test/CMakeLists.txt:129 if(LLDB_BUILD_FRAMEWORK) list(APPEND LLDB_TEST_COMMON_ARGS --framework $) endif() We'll have to do the same thing here, but the debugserver is more pressing as it's keeping GreenDragon

[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

2018-05-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: stella.stamenova, zturner, davide. Herald added subscribers: jkorous, mgorny. Because we can't expand generator expressions for the lit tests, we need to set the path to the debugserver in the `_STR` variable so it's expanded prope