This revision was automatically updated to reflect the committed changes.
Closed by commit rL331463: [CMake] Unify and relayer testing (authored by
JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46334?vs=145033&id=145035#toc
Repository:
rL LLVM
https://revi
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
I still need to verify this works with VS on Windows, but feel free to check in
to unblock the bots
https://reviews.llvm.org/D46334
JDevlieghere updated this revision to Diff 145033.
JDevlieghere added a comment.
Herald added a reviewer: alexshap.
update diff pro forma
https://reviews.llvm.org/D46334
Files:
CMakeLists.txt
lit/CMakeLists.txt
lit/Suite/lit.site.cfg.in
test/CMakeLists.txt
test/lldb-dotest.in
tools/
labath added subscribers: aprantl, davide, JDevlieghere, zturner.
labath added a comment.
I remember hearing some people use the check-lldb-single target, but it had
to do with running the tests against some remote devices/stubs that did not
handle multiple connections very well.
However, the way
I remember hearing some people use the check-lldb-single target, but it had
to do with running the tests against some remote devices/stubs that did not
handle multiple connections very well.
However, the way it seems to me, with the transition to lit, this target
will have to go away sooner or lat
JDevlieghere added a comment.
I didn't realize `check-lldb-single` was also broken for ninja/make. Using the
property indeed fixed it, so we can land this without the caveat.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commit
aprantl added a comment.
> If by as-is you mean with a big comment in the config file before the
> creation of check-single that it is broken, then yes, let's get the bots
> unblocked and then fix the issue.
Sounds good. Thanks!
https://reviews.llvm.org/D46334
_
stella.stamenova added a comment.
If by as-is you mean with a big comment in the config file before the creation
of check-single that it is broken, then yes, let's get the bots unblocked and
then fix the issue.
https://reviews.llvm.org/D46334
___
aprantl added a comment.
If that's okay with you I would suggest landing this as is to unblock the bots,
and we'll keep working on fixing the check-single target ASAP, too.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commits@
stella.stamenova added a comment.
In its current version, the patch won't *break* the windows build (the previous
change broke the build as well as tests), so if it will unblock the bots, Jonas
could check it in and then fix check-single in a follow up patch. I think it
needs to be explicit if
aprantl added a comment.
Is there a way to land a partial version of this patch to un-block the green
dragon bots and keep iterating on the check-single target separately? Or do
other bots depend on check-single working correctly? I'm really uneasy about
the fact that we are loosing signal from
JDevlieghere added inline comments.
Comment at: test/CMakeLists.txt:101
${LLDB_SOURCE_DIR}/test/dotest.py
"--no-multiprocess;${LLDB_DOTEST_ARGS}"
"Testing LLDB with args: ${LLDB_DOTEST_ARGS}"
stella.stamenova wrote:
> LLDB_DOTEST_ARGS are passed here, bu
stella.stamenova added a comment.
The tests passed, but check-single was not created correctly. I added a comment
above.
Comment at: test/CMakeLists.txt:101
${LLDB_SOURCE_DIR}/test/dotest.py
"--no-multiprocess;${LLDB_DOTEST_ARGS}"
"Testing LLDB with args: ${LLDB_DOTES
JDevlieghere updated this revision to Diff 144893.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
- Address review feedback Stella
https://reviews.llvm.org/D46334
Files:
CMakeLists.txt
lit/CMakeLists.txt
lit/Suite/lit.site.cfg.in
test/CMakeLists.txt
test/
stella.stamenova added a comment.
I am going to run the tests after you make the last few changes. I want to make
sure the compiler path is no longer being overwritten by the test cmake before
I run them.
Comment at: test/CMakeLists.txt:138
if(CMAKE_HOST_APPLE)
- list(APPEN
labath added a comment.
Looks fine to me, but I don't use multi-config generators. I'll let you and
Stella work out the details there.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
JDevlieghere added a comment.
@stella.stamenova Would you mind applying this locally and verify if it works
for the MSVC generator? It seems to work for the Xcode generator but it's
always possible that I missed something.
https://reviews.llvm.org/D46334
JDevlieghere updated this revision to Diff 144853.
JDevlieghere retitled this revision from "[lit] Make debugserver available to
lit test" to "[CMake] Unify and relayer testing".
JDevlieghere edited the summary of this revision.
JDevlieghere added reviewers: labath, aprantl.
JDevlieghere added a c
18 matches
Mail list logo
