This revision was automatically updated to reflect the committed changes.
Closed by commit rL331197: Reflow paragraphs in comments. (authored by adrian,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46144?vs=144420&id=144575#toc
Rep
aprantl added inline comments.
Comment at: source/Host/common/MainLoop.cpp:158
// ppoll(2) is not supported on older all android versions. Also, older
- // versions android (API <= 19) implemented pselect in a non-atomic way, as a
- // combination of pthread_sigmask and sele
JDevlieghere accepted this revision.
JDevlieghere added a comment.
👍
Comment at: source/Host/common/MainLoop.cpp:158
// ppoll(2) is not supported on older all android versions. Also, older
- // versions android (API <= 19) implemented pselect in a non-atomic way, as a
- //
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me, I guess if noone objects, we can land this. Thanks for doing
this.
https://reviews.llvm.org/D46144
___
lldb-commits mailing li
aprantl updated this revision to Diff 144420.
aprantl added a comment.
Updated the script based on Pavel's feedback:
import textwrap
import commands
import os
import sys
import re
tmp = "%s.tmp"%sys.argv[1]
out = open(tmp, "w+")
with open(sys.argv[1], "r") as f:
header = ""
labath added a comment.
The formatting of the comments has been bugging me as well. So far, I have been
trying to reflow them whenever I touch the code around them, but at that rate
fixing all of them would take ages.
Your heuristics seem to be working fairly well. I've found a couple of
sub-o
aprantl created this revision.
aprantl added reviewers: clayborg, jingham, jasonmolenda, labath.
Herald added subscribers: mgrang, JDevlieghere, kbarton, arichardson, nemanjai,
kubamracek, emaste, srhines.
Herald added a reviewer: javed.absar.
Herald added a reviewer: espindola.
This is intended
