[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

This revision was automatically updated to reflect the committed changes. Closed by commit rL328649: [Core] Correctly handle float division in Scalar. (authored by davide, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44693 Files: lld

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

davide added a comment. Allright, we got this one. davide@Davidinos-Mac-Pro ~/w/l/l/lldb> git llvm push Pushing 1 commit: 55f24c19d1c [Core] Correctly handle float division in Scalar. Sendinglldb/trunk/source/Core/Scalar.cpp Sendinglldb/trunk/unittests/Core/ScalarTest.cpp Tran

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

tromey added a comment. In https://reviews.llvm.org/D44693#1046925, @davide wrote: > LGTM, thanks. Do you have commit access or you need somebody to commit this > on your behalf? I do not have commit access. https://reviews.llvm.org/D44693 ___ l

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

davide accepted this revision. davide added a comment. LGTM, thanks. Do you have commit access or you need somebody to commit this on your behalf? https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

tromey updated this revision to Diff 139616. tromey added a comment. Add unit test https://reviews.llvm.org/D44693 Files: source/Core/Scalar.cpp unittests/Core/ScalarTest.cpp Index: unittests/Core/ScalarTest.cpp === --- unitt

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

clayborg added a comment. Bonus points for catching any other conversion errors that don't match the current C/C++ specs. The unit tests should be an easy place to test these kinds of things. https://reviews.llvm.org/D44693 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

davide added a comment. Yes, this needs a test. Thanks! https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

clayborg added a comment. Seems like a unit test would work well in this case. https://reviews.llvm.org/D44693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Actually, we should add a test for this to ensure this doesn't regress. https://reviews.llvm.org/D44693 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D44693: Correctly handle float division in Scalar

tromey added a comment. I've also noticed that int->float conversion in Scalar seems incorrect. At least, Scalar.h claims that Scalar follows C promotion rules, but int->float conversion is done using bitwise reinterpretation rather than preserving the value. I have a patch for this, but I do