This revision was automatically updated to reflect the committed changes.
Closed by commit rL328984: Support template template parameters (authored by
friss, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44613
Files:
lldb/trunk/includ
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sorry for the delay.
https://reviews.llvm.org/D44613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
friss added a comment.
Ping
https://reviews.llvm.org/D44613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
friss updated this revision to Diff 139619.
friss added a comment.
Use LLVM macro for fallthrough
https://reviews.llvm.org/D44613
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/template/TestTemplateArgs.py
packages/Python/lldbsuite/test/lang/cpp/templ
friss added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2043
+is_template_template_argument = true;
+[[clang::fallthrough]];
case DW_TAG_template_type_parameter:
clayborg wrote:
> Shouldn't we be using a #define
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2043
+is_template_template_argument = true;
+[[clang::fallthrough]];
case DW_TAG_template_type_parameter:
Shouldn't we be using a #define so this works
friss created this revision.
friss added reviewers: clayborg, jingham.
Herald added a subscriber: JDevlieghere.
We would fail to resolve (and thus display the value of) any
templated type which contained a template template argument even
though we don't really use template arguments.
This patch a
