[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 138370. JDevlieghere added a comment. Yeah, that's more sensible indeed. I must have had `llvm-lit` in mind and never gave it a second thought. Repository: rL LLVM https://reviews.llvm.org/D44473 Files: test/CMakeLists.txt test/lldb-dotest.in

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. The name should be changed (also the utility name), but that should be done separately. Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Also, I second the feeling of having `lldb` somewhere in the name for the utility (rather than `llvm` :) Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a subscriber: JDevlieghere. zturner added a comment. Shouldn’t it be lldb-dotest? I’m confused about what this target does Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Zachary Turner via lldb-commits
Shouldn’t it be lldb-dotest? I’m confused about what this target does On Wed, Mar 14, 2018 at 8:21 AM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide accepted this revision. > davide added a comment. > This revision is now accepted and ready to land. > > LGTM > > > Repo

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D44473 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[Lldb-commits] [PATCH] D44473: [dotest] Make llvm-dotest a custom target

2018-03-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: davide, labath, zturner. Herald added subscribers: llvm-commits, mgorny. This makes llvm-dotest a custom target so you can run `ninja llvm-dotest` to rebuild whatever is necessary before rerunning the tests. Repository: rL LLVM