This revision was automatically updated to reflect the committed changes.
Closed by commit rL327123: [elf] Remove one copy of the section merging code
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44157
Files:
lld
jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.
Yes, it should be the same I think; some notes of mine:
Module::GetSectionList()->obj_file->CreateSections(*GetUnifiedSectionList());
Module::GetUnifiedSectionList()->
labath created this revision.
labath added reviewers: fjricci, jankratochvil.
Herald added subscribers: arichardson, emaste.
Besides being superfluous, this double merging was actually wrong and
causing some sections to be added twice. The reason for that was that
the code assumes sectoin IDs are
