[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

2018-03-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere planned changes to this revision. JDevlieghere added a comment. Alright, sounds good. Thank you both for the help! Repository: rL LLVM https://reviews.llvm.org/D44139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

2018-03-06 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Change looks fine to me. > What's the best/easiest way to test this? You can just run: (lldb) process save-core /tmp/test.core" This will allow you to take any process and save a core file for it from lldb. Then you could obj2yaml it and check that part in. This is

[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

2018-03-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I don't know much about OS plugins, but I don't see a reason why this would be mach-specific (so yes, it should probably be done for elf cores as well). Oh, and we also have windows minidumps, but I'm not sure if it should be up to you to update all of these (I'm saying

[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

2018-03-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, labath. Herald added a subscriber: llvm-commits. The OS plugins might have updated the thread list after a core file has been loaded. The physical thread in the core file may no longer be the one that should b