This revision was automatically updated to reflect the committed changes.
Closed by commit rL326514: Speed up TestWatchpointMultipleThreads (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43857
Files:
lldb/trunk/pa
clayborg added a comment.
very nice!
https://reviews.llvm.org/D43857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Great, thanks!
https://reviews.llvm.org/D43857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
labath updated this revision to Diff 136368.
labath added a comment.
Replace all tabs in the python file and clang-format the cpp file.
https://reviews.llvm.org/D43857
Files:
packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
packag
xiaobai added a comment.
Thanks for taking the time to do this!
Can you please double check some of the formatting in the python code? It looks
like it's not indented properly.
https://reviews.llvm.org/D43857
___
lldb-commits mailing list
lldb-com
labath updated this revision to Diff 136361.
labath added a comment.
This makes the inferior more simple and deterministic by using a single thread.
Now we have one test which sets the watchpoint before the thread is created and
one that sets it after. I've also simplified the test a bit with new
jingham added a comment.
Thanks!
While it seems possible somebody could write code that only sets the control
registers on one thread and then gets tired and goes out for a beer, that seems
like a really unlikely error. I don't think it's worth complicating the test
to catch that possibility.
labath added a comment.
That's a good point. I think that at least TestConcurrentEvents do it that way,
but they are testing a different thing. I think it makes sense to test both
things here actually. I'll create one test which sets the watchpoint before
thread creation and one after.
BTW, do
jingham added a comment.
Getting watchpoints to propagate to threads that are created after the
watchpoint has been set is one of the trickier parts of watchpoint propagation.
On macOS, (where we don't get new thread creation notification) we rely on the
kernel to propagate the control regist
labath created this revision.
labath added reviewers: davide, jingham.
Herald added a subscriber: aprantl.
The inferior was sleeping before doing any interesting work. I remove that
to make the test faster.
While looking at the purpose of the test (to check that watchpoints are
propagated to all
10 matches
Mail list logo
