This revision was automatically updated to reflect the committed changes.
Closed by commit rL325836: Fix TestMoveNearest on Windows (authored by
amccarth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43600?vs=135345&id=135524#toc
R
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ok, that's the piece that was missing since the code for `foo.cpp` and
`main.cpp` weren't part of the patch.
https://reviews.llvm.org/D43600
_
amccarth added a comment.
call_foo1() is defined in foo.cpp, which is built into a DLL, and thus needs
the __declspec(dllimport/dllexport) from the LLDB_TEST_API. foo.h defines the
API for the DLL.
call_foo2() is defined in main.cpp, which is built into an executable that
depends on foo.dll.
zturner added a comment.
How is `call_foo2` any different than `call_foo1`, which was not removed from
this patch?
https://reviews.llvm.org/D43600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
amccarth added a comment.
In https://reviews.llvm.org/D43600#1016483, @zturner wrote:
> Do we not need `call_foo2` anymore?
call_foo2 is defined in the executable, so attempting to report it as dllexport
from the DLL is nonsensical and causes link-time errors.
https://reviews.llvm.org/D43600
zturner added a comment.
Do we not need `call_foo2` anymore?
https://reviews.llvm.org/D43600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amccarth created this revision.
amccarth added a reviewer: zturner.
Herald added a subscriber: sanjoy.
The header file for the DLL tried to declare inline functions and a local
function as dllexport which broke the compile and link. Removing the bad
declarations solves the problem, and the test p
