amccarth added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/unicode/TestUnicodeSymbols.py:13
+self.build()
+ spec = lldb.SBModuleSpec()
+ spec.SetFileSpec(lldb.SBFileSpec(self.getBuildArtifact("a.out")))
Oops!
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325927: Replace HashStringUsingDJB with llvm::djbHash
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43596?vs=135568&id=
aprantl added a comment.
Nice!
https://reviews.llvm.org/D43596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath updated this revision to Diff 135568.
labath added a comment.
This adds a test which looks up a type with unicode characters. I have verified
this test does not pass when run against a pre-D42740 compiler.
https://reviews.llvm.org/D43596
Files:
include/lldb/Core/MappedHash.h
packages
aprantl added a comment.
In https://reviews.llvm.org/D43596#1015903, @clayborg wrote:
> The only input we currently use this on is DWARF and I believe all DWARF
> strings are UTF8 so this should all work correctly, no?
The hashing algorithms produced different hashes for characters with bit 7
clayborg added a comment.
The only input we currently use this on is DWARF and I believe all DWARF
strings are UTF8 so this should all work correctly, no?
https://reviews.llvm.org/D43596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
JDevlieghere added a comment.
In https://reviews.llvm.org/D43596#1015848, @clayborg wrote:
> No need to add additional dSYM tests, because all dSYM tests will fail if the
> hashing isn't correct.
Maybe I misunderstand, but https://reviews.llvm.org/D42740 suggested that this
never worked (or m
clayborg accepted this revision.
clayborg added a comment.
No need to add additional dSYM tests, because all dSYM tests will fail if the
hashing isn't correct.
https://reviews.llvm.org/D43596
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
JDevlieghere added a reviewer: JDevlieghere.
JDevlieghere added a comment.
We probably want to have a test to ensure this stays in sync with the hashes we
generate for object files and dSYMs?
https://reviews.llvm.org/D43596
___
lldb-commits mailing
davide accepted this revision.
davide added a comment.
Thanks.
https://reviews.llvm.org/D43596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: include/lldb/Core/MappedHash.h:156
- template
- class ExportTable {
- public:
Yeah this looks like it was a dead end dating back to 201
labath created this revision.
labath added reviewers: aprantl, davide.
Herald added a subscriber: JDevlieghere.
The llvm function is equivalent to this one. Where possible I tried to
replace const char* with llvm::StringRef to avoid extra strlen
computations. In most places, I was able to track th
12 matches
Mail list logo
