[Lldb-commits] [PATCH] D42994: Only throw -fPIC when building a shared library

2018-02-08 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:49 os.mkdir(newdir) -except OSError, e: +except OSError as e: if e.errno != os.errno.EEXIST: -

[Lldb-commits] [PATCH] D42994: Only throw -fPIC when building a shared library

2018-02-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This lgtm. If this causes some tests that were previously skipped or xfailed to start passing, you can unskip / unxfail them at the same time. Comment at: packages/Pytho