mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359
+ // p = patchlevel
+ const uint32_t version_major = version_info / 1;
+ const uint32_t version_minor = (version_info
krytarowski planned changes to this revision.
krytarowski added a comment.
Herald added a subscriber: arichardson.
I will be back to this once I will be done with debugging client-server
connectivity issues (unrelated to this patch).
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
labath added a comment.
Extending lldb-test's dumpModules() to also dump out the module's triple sounds
like a reasonable thing to do (I am assuming that the Module class will do
something reasonable when given an object file with no sections, like a core
file -- if not we could make a separate
jingham added a comment.
There is code in the GDBRemoteTestBase that makes targets from yaml2obj. See
the createTarget method in
packages/Python/lldbsuite/functionalities/gdb_remote_client/gdbclientutils.py.
Actually, that's method should be pulled out of the gdb_remote_client and moved
to T
davide added a subscriber: zturner.
davide added a comment.
In https://reviews.llvm.org/D42870#996913, @krytarowski wrote:
> Is there a working example of this? I would clone an existing code for Linux
> or other supported OS and adapt it for NetBSD.
>
> Please note that I'm in the process of re
krytarowski added a comment.
Is there a working example of this? I would clone an existing code for Linux or
other supported OS and adapt it for NetBSD.
Please note that I'm in the process of restoration LLDB (lldb-server) so I
cannot execute regular tests, at least in close time.
Repository:
davide added a comment.
In https://reviews.llvm.org/D42870#996899, @clayborg wrote:
> Probably take a ELF file that is NetBSD and obj2yaml it. The test would run
> yaml2obj on it and then test that things are recognized correctly via the SB
> interfaces (check triple is correct)?
The SBApi in
clayborg added a comment.
You would check in the YAML code for the NetBSD ELF file so that the test case
can make it into an ELF file, run the test, verify things, and then cleanup the
created ELF file.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
_
clayborg added a comment.
Probably take a ELF file that is NetBSD and obj2yaml it. The test would run
yaml2obj on it and then test that things are recognized correctly via the SB
interfaces (check triple is correct)?
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
krytarowski added a comment.
What would the test do?
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Please add a test case.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
krytarowski created this revision.
krytarowski added reviewers: joerg, labath.
Herald added subscribers: llvm-commits, emaste.
Split the recognition into NetBSD executables
& shared libraries and core(5) files.
Introduce new owner type: "NetBSD-CORE",
as core(5) files are not tagged in the same w
krytarowski added a comment.
Extracted from: https://reviews.llvm.org/D32149.
Repository:
rL LLVM
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
13 matches
Mail list logo
