This revision was automatically updated to reflect the committed changes.
Closed by commit rL324707: [SymbolFilePDB] Add support for function symbols
(authored by asmith, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42443?vs=133561&id=133562#toc
Repository:
rL LLVM
htt
asmith updated this revision to Diff 133561.
asmith added a comment.
Minor cleanup before commit
https://reviews.llvm.org/D42443
Files:
lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp
lit/SymbolFile/PDB/Inputs/FuncSymbolsTestMain.cpp
lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
lit/SymbolFil
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Sorry for the delay on this one, looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D42443
___
lldb-commits mailing list
lldb-commits@
asmith updated this revision to Diff 132785.
Repository:
rL LLVM
https://reviews.llvm.org/D42443
Files:
lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp
lit/SymbolFile/PDB/Inputs/FuncSymbolsTestMain.cpp
lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
lit/SymbolFile/PDB/func-symbols.test
sourc
Well... it would be *very*-nice-to-have thing. I would very much love
to be able to run at least one pdb test from linux. (So, I'm not
opposing this in any way, just pointing out what needs to happen).
On 1 February 2018 at 18:35, Zachary Turner wrote:
> Yea good point. We can probably punt on th
Yea good point. We can probably punt on this for now as it’s just a
nice-to-have
On Thu, Feb 1, 2018 at 1:38 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added inline comments.
>
>
>
> Comment at: lit/SymbolFile/PDB/func-symbols.test:4
> +RUN: clang-
labath added inline comments.
Comment at: lit/SymbolFile/PDB/func-symbols.test:4
+RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/FuncSymbols.cpp /o
%T/FuncSymbols.cpp.obj
+RUN: link %T/FuncSymbolsTestMain.cpp.obj %T/FuncSymbols.cpp.obj /DEBUG
/nodefaultlib /Entry:main /OUT:%T/FuncSym
zturner added inline comments.
Comment at: lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp:2
+// Static function
+static long StaticFunction(int a)
+{
Would it be worth trying one in an anonymous namespace?
Comment at: lit/SymbolFile/PDB/func-symbols
asmith created this revision.
asmith added reviewers: zturner, lldb-commits.
Herald added a subscriber: llvm-commits.
This is combination of following changes,
- Resolve function symbols in PDB symbol file. `lldb-test symbols` will display
information about function symbols.
- Implement SymbolF
