[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

This revision was automatically updated to reflect the committed changes. Closed by commit rL323085: Fix memory leaks in MinidumpParserTest (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42347?vs=130846&id=1308

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

teemperor updated this revision to Diff 130846. teemperor added a comment. - Using make_unique now. https://reviews.llvm.org/D42347 Files: unittests/Process/minidump/MinidumpParserTest.cpp Index: unittests/Process/minidump/MinidumpParserTest.cpp =

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

zturner added a comment. Same as with the last one. For obviously correct bug fixes like this, just commit them. As an aside, `make_unique` will make this a bit shorter so it fits on one line. e.g. `auto reg_interface = llvm::make_unique(arch);` https://reviews.llvm.org/D42347 _

[Lldb-commits] [PATCH] D42347: Fix memory leaks in MinidumpParserTest

teemperor created this revision. teemperor added a reviewer: dvlahovski. We never delete the allocated RegisterContext objects, causing those tests to fail with enabled memory sanitizer. https://reviews.llvm.org/D42347 Files: unittests/Process/minidump/MinidumpParserTest.cpp Index: unittes