This revision was automatically updated to reflect the committed changes.
Closed by commit rL322666: [lldb][PPC64] Fixed long double variables dump
(authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D42083
Files:
lldb/trunk/source/Core/DumpDataExtractor.cpp
luporl added a comment.
@labath, can you please commit the changes for me? (I don't have permission to
do it)
https://reviews.llvm.org/D42083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Awesome, thanks.
https://reviews.llvm.org/D42083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
luporl updated this revision to Diff 129939.
luporl added a comment.
Changed implementation to make only x87DoubleExtended a special case.
https://reviews.llvm.org/D42083
Files:
source/Core/DumpDataExtractor.cpp
Index: source/Core/DumpDataExtractor.cpp
==
luporl added a comment.
@labath, the change you suggested really looks better, by reducing the number
of special cases.
I tested it on PPC64 and it also fixes the issue, as expected.
I'll update the diff.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D42083
__
labath added a comment.
This adds a special case to "long double" logic, which is already a special
case compared to "float" and "double" cases. This was written this way (see
http://reviews.llvm.org/D8417) because the x86 long double type is special, but
if I understand this correctly, for the
