This revision was automatically updated to reflect the committed changes.
Closed by commit rL319414: Fix assertion in ClangASTContext (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D40615?vs=124781&id=124890#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40615
F
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Symbol/CompilerType.h:294
+ struct IntegralTemplateArgument;
+
clayborg wrote:
> Can't you just define the type right here?
Unfortunately, I can't because it contai
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Few nits, but nothing that would hold up the patch. Looks good.
Comment at: include/lldb/Symbol/CompilerType.h:294
+ struct IntegralTemplateArgument;
+
---
labath created this revision.
llvm::APSInt(0) asserts because it creates an int with bit-width 0 and
not (as I thought) a value 0.
Theoretically it should be sufficient to change this to APSInt(1), as
the intention there was that the value of the first argument should be
ignored if the type is in
