jankratochvil added a comment.
> Please undo all renaming from offset to file_offset.
I am preparing now a split of this patch for the renaming part + the "real"
part, sorry I did not realize it is mostly about the renaming which is not
worth your detailed review.
There are two different types
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please undo all renaming from offset to file_offset. The "offset" you get from
a DIE should always be the absolute .debug_info offset. No need to say
file_offset. Patch will be
jankratochvil updated this revision to Diff 124803.
jankratochvil marked an inline comment as done.
jankratochvil added a comment.
Removed excessive: #include:
https://reviews.llvm.org/D40467
Files:
include/lldb/Expression/DWARFExpression.h
source/Expression/DWARFExpression.cpp
source/Pl
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:15
#include
+#include
clayborg wrote:
> Why is this added here? Doesn't seem to be needed, or it should be moved
clayborg added a comment.
It would be much easier to read this patch if there were no renames from
"*offset" to "*file_offset". Can we remove these extra renames where it isn't
needed?
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:15
#include
+#include
---
