This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL318145: Add a data formatter for libc++ std::bitset
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D39966?vs=122685&id=122808#toc
Repos
labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:62
+
+ m_bool_type =
m_backend.GetCompilerType().GetBasicTypeFromAST(eBasicTypeBool);
+ m_elements.assign(size, ValueObjectSP());
-
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks fine. Seems like Update doesn't need to grab the bool type on every
pass, but I don't think that matters IRL. Thanks for adding this.
Comment at: source/Plugins/La
labath created this revision.
Herald added a subscriber: mgorny.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D39966
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/bitset/Makefile
packages/Python/lldbsuite/test/functionalities/dat
