This revision was automatically updated to reflect the committed changes.
Closed by commit rL318046: Remove last Host usage from ArchSpec (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D39896?vs=122416&id=122651#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3989
labath added a comment.
If I understand correctly, everyone agrees with this change, so I will commit
it soon(ish). Below are my thoughs on some of the things said in this thread.
@zturner wrote:
> Super awesome. When you do move it to Utility, can you run the deps python
> script to see if an
zturner added a comment.
In https://reviews.llvm.org/D39896#922381, @probinson wrote:
> Drive by comment:
>
> In https://reviews.llvm.org/D39896#94, @jingham wrote:
>
> > You're right, the Triple stuff is in ADT! I was using it as an example of
> > something you clearly wouldn't do so I did
probinson added a comment.
Drive by comment:
In https://reviews.llvm.org/D39896#94, @jingham wrote:
> You're right, the Triple stuff is in ADT! I was using it as an example of
> something you clearly wouldn't do so I didn't actually check to see if it was
> done. That's pretty funny.
>
>
jingham added a comment.
Yes, my intention was not to gate this patch on figuring out the right role for
Utility/Core/Whatever. It just seemed an apropos moment to bring this up.
You're right, the Triple stuff is in ADT! I was using it as an example of
something you clearly wouldn't do so I d
zturner added a comment.
I'd be open to having another organizational component that isn't Utility. But
as Jim said, there isn't a critical mass of stuff yet in Utility to figure out
where it makes sense to draw the line.
In all honesty, that second component might just end up being "Core" aga
clayborg added a comment.
I just saw Jim's email for this, Please comment in this bug so we can all see
the info in one location. Accepting pending the outcome of the discussion that
Jim start in email that I am pasting below:
> I'm not sure we have enough instances to decide on better organiza
I'm not sure we have enough instances to decide on better organization, but
ArchSpec really doesn't feel like a Utility for lldb. That would be like
moving the llvm triple handling to ADT, that seems a little weird. Similarly
having the register stuff in Utility seems odd as well. I would nev
Super awesome. When you do move it to Utility, can you run the deps python
script to see if any cmake dependencies can be updated?
On Fri, Nov 10, 2017 at 4:02 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
>
> In https://reviews.llvm.org/D39387,
labath created this revision.
In https://reviews.llvm.org/D39387, I was quick to jump to conclusion that
ArchSpec has no
external dependencies. It turns there still was one call to
HostInfo::GetArchitecture left -- for implementing the "systemArch32"
architecture and friends.
Since GetAugmentedA
10 matches
Mail list logo
