clayborg added a comment.
Sorry for the delay, I was out on vacation for a week.
Repository:
rL LLVM
https://reviews.llvm.org/D38323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
labath added a comment.
In https://reviews.llvm.org/D38323#889534, @alexandreyy wrote:
> In https://reviews.llvm.org/D38323#889473, @labath wrote:
>
> > Looks fine to me. Sorry about the delay.
> >
> > @eugene should be able to help you commit this.
> >
> > Wrt. the extra register context discuss
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315008: Enable breakpoints and read/write GPRs for ppc64le
(authored by eugene).
Repository:
rL LLVM
https://reviews.llvm.org/D38323
Files:
lldb/trunk/source/Plugins/Process/Linux/CMakeLists.txt
l
alexandreyy added a comment.
In https://reviews.llvm.org/D38323#889473, @labath wrote:
> Looks fine to me. Sorry about the delay.
>
> @eugene should be able to help you commit this.
>
> Wrt. the extra register context discussion, I believe you will need to
> implement an extra class or two when
labath added a reviewer: eugene.
labath accepted this revision.
labath added a subscriber: eugene.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine to me. Sorry about the delay.
@eugene should be able to help you commit this.
Wrt. the extra register context dis
alexandreyy added a comment.
Hi,
Could you review/approve this patch, please?
I do not have commit permission.
I will add other register sets later.
Thanks! ;)
https://reviews.llvm.org/D38323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
alexandreyy added a comment.
Are these changes ok?
I am implementing the read/write functions for the other registers.
And I will add it later.
In https://reviews.llvm.org/D38323#883429, @clayborg wrote:
> Looks fine. One main questions for new linux archs in particular: is linux
> using the ll
alexandreyy updated this revision to Diff 117197.
alexandreyy marked 6 inline comments as done.
alexandreyy added a comment.
Remove duplicated structs and change register set types
https://reviews.llvm.org/D38323
Files:
source/Plugins/Process/Linux/CMakeLists.txt
source/Plugins/Process/Linu
alexandreyy marked 6 inline comments as done.
alexandreyy added a comment.
In https://reviews.llvm.org/D38323#883429, @clayborg wrote:
> Looks fine. One main questions for new linux archs in particular: is linux
> using the lldb-server to debug these days even when debugging locally? If so,
> t
clayborg added a comment.
Looks fine. One main questions for new linux archs in particular: is linux
using the lldb-server to debug these days even when debugging locally? If so,
then this patch only needs to implement both a native register content and not
the lldb_private::RegisterContext sub
clayborg added inline comments.
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:71
+ RegInfo m_reg_info;
+ Reg m_gpr_ppc64le[48]; // 64-bit general purpose registers.
+
Could we share the structure that backs all registers from the
alexandreyy created this revision.
Herald added subscribers: JDevlieghere, kbarton, mgorny, nemanjai.
Add support for ppc64le to create breakpoints and read/write
general purpose registers.
Other features for ppc64le and functions to read/write
other registers are being implemented.
https://re
12 matches
Mail list logo
