[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene closed this revision. eugene added a comment. Checked in as r309648 https://reviews.llvm.org/D36126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene added a comment. clang drew my attention to it: Symtab.cpp:620:5: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] std::unique(indexes.begin(), indexes.end()); ^~~ ~~ https://reviews.llvm.o

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This bug has been there since the first llvm.org checkin. I'm curious, did it actually cause a problem or did you just see it while reading? The patch is right. Most of the other uses elid

[Lldb-commits] [PATCH] D36126: Fix incorrect use of std::unique

2017-07-31 Thread Eugene Zemtsov via Phabricator via lldb-commits
eugene created this revision. eugene added a project: LLDB. https://reviews.llvm.org/D36126 Files: source/Symbol/Symtab.cpp Index: source/Symbol/Symtab.cpp === --- source/Symbol/Symtab.cpp +++ source/Symbol/Symtab.cpp @@ -616,8 +