[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

This revision was automatically updated to reflect the committed changes. Closed by commit rL311002: Make i386-*-freebsd expression work on JIT path (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D34776?vs=104984&id=111331#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

labath accepted this revision. labath added a comment. lgtm https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. I've committed this to FreeBSD's copy of lldb in r322326 . @labath if you're happy with this patch I will commit to lldb for @karnajitw. I'm not sure how the patch ended up with a conflict, but it's just a whitespace issue. https:/

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. With this patch i386 test results are comparable to amd64, and I'm happy with it from a FreeBSD perspective (modulo the PlatformOpenBSD patch conflict). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. The change in PlatformOpenBSD.cpp failed to apply for me (although it was trivial to manually apply it). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. Sorry I missed this when first uploaded, I will look at it shortly. For future uploads can you kindly include full context, as described in https://llvm.org/docs/Phabricator.html? https://reviews.llvm.org/D34776 ___ lldb-co

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

karnajitw marked an inline comment as done. karnajitw added a comment. With my test setup on i386-*-freebsd-11.0 (freebsd patched).. There seems to be quite a good improvement in the number of test failures. [BEFORE lldb patch] === Test Result Summary === Test M

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

labath added a reviewer: emaste. labath added a comment. +ed as freebsd owner ArrayRef cannot be returned from a function as they don't own the underlying data. The more traditional way of using SmallVector is to "return" it as a by-ref `SmallVectorImpl` argument, as that avoids the need to har

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

karnajitw updated this revision to Diff 104984. karnajitw added a comment. Done the changes. Please verify. Tried with RefArray but looks like they don't work well with copy. https://reviews.llvm.org/D34776 Files: include/lldb/Target/Platform.h source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

karnajitw added a comment. Looks like the right thing to do. I will make the changes accordingly. Repository: rL LLVM https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

labath added inline comments. Comment at: source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:92 clang_ast_context->GetBasicType(eBasicTypeVoid).GetPointerType(); -lldb::addr_t args[] = {addr, length, prot_arg, flags_arg, fd, offset}; +llvm::SmallVec

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

karnajitw added a comment. Adding the corresponing reference discussions with freebsd folks. mmap - https://lists.freebsd.org/pipermail/freebsd-hackers/2017-May/051072.html x87 tag- https://lists.freebsd.org/pipermail/freebsd-hackers/2017-June/051166.html Repository: rL LLVM https://reviews

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

karnajitw created this revision. Herald added a subscriber: emaste. Expression evaluation which takes the non IRInterpreter::Interpret path fails on i386-*-freebsd. Following changes are done to enable it. 1. Enable i386 ABI creation for freebsd 2. Added an extra argument in ABISysV_i386::Prepar