[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-20 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL305779: Remove home-grown thread-local storage wrappers (authored by labath). Changed prior to commit: https://reviews.llvm.org/D34274?vs=102810&id=103169#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-19 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. We have thread local storage support on all our current darwin platforms. https://reviews.llvm.org/D34274 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D34274#782529, @zturner wrote: > The last time I tried to do this we couldn't because it didn't yet work on > iOS. I checked with some Apple people though and they said `thread_local` > support was released last year on all Apple platforms.

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-16 Thread Ed Maste via Phabricator via lldb-commits
emaste added a comment. Fine from FreeBSD https://reviews.llvm.org/D34274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-16 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Modern BSDs should be fine on popular platforms. https://reviews.llvm.org/D34274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-16 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. The last time I tried to do this we couldn't because it didn't yet work on iOS. I checked with some Apple people though and they said `thread_local` support was released last year on all Apple platforms. So hopefully there's no more hurdles to getting this in. https

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

2017-06-16 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Use c++11 thread_local variables instead. As far as I am aware, they are supported by all compilers/targets we care about. https://reviews.llvm.org/D34274 Files: include/lldb/Host/Host.h source/Core/Timer.cpp source/Host/common/Host.cpp source/Host/windows/