This revision was automatically updated to reflect the committed changes.
Closed by commit rL307009: Use llvm::sys::RetryAfterSignal instead of a manual
while errno!=EINTR loop (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D33831?vs=101212&id=105067#toc
Repository:
labath added inline comments.
Comment at: include/lldb/Host/Host.h:252
+result = f(args...);
+ while (result == fail_value && errno == EINTR);
+ return result;
krytarowski wrote:
> Will this build on Windows for their native API? If so, will it be useful
>
Maybe just ask on llvm dev what people's thoughts are?
On Fri, Jun 2, 2017 at 7:51 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath updated this revision to Diff 101212.
> labath added a comment.
>
> - fix freebsd typo
> - use ::waitpid consistently
>
>
> https://reviews
krytarowski added inline comments.
Comment at: include/lldb/Host/Host.h:252
+result = f(args...);
+ while (result == fail_value && errno == EINTR);
+ return result;
Will this build on Windows for their native API? If so, will it be useful there?
https://r
labath updated this revision to Diff 101212.
labath added a comment.
- fix freebsd typo
- use ::waitpid consistently
https://reviews.llvm.org/D33831
Files:
include/lldb/Host/Host.h
source/Host/common/File.cpp
source/Host/macosx/Host.mm
source/Host/posix/ConnectionFileDescriptorPosix.cpp
I've wondered about that as well.. I've seen a couple of places where
this could be useful, but not nearly as many as in lldb. I'll let you
be the judge of that.
On 2 June 2017 at 15:43, Zachary Turner wrote:
> I wonder if this should go in LLVM?
>
> On Fri, Jun 2, 2017 at 7:35 AM Pavel Labath vi
krytarowski added inline comments.
Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:788
-WAIT_AGAIN:
- // Wait for the operation thread to initialize.
- if (sem_wait(&args->m_semaphore)) {
-if (errno == EINTR)
- goto WAIT_AGAIN;
-else {
- error.
I wonder if this should go in LLVM?
On Fri, Jun 2, 2017 at 7:35 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
> Herald added subscribers: mgorny, emaste.
>
> It is intended to wrap functions which can fail with EINTR (which we
> have a surprisin
labath created this revision.
Herald added subscribers: mgorny, emaste.
It is intended to wrap functions which can fail with EINTR (which we
have a surprising number of). It is inspired by the TEMP_FAILURE_RETRY
macro in glibc, but I've c++-ified it and made it more generic (by
specifying an expli
