This revision was automatically updated to reflect the committed changes.
Closed by commit rL301636: Resurrect pselect MainLoop implementation (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D32600?vs=97074&id=97075#toc
Repository:
rL LLVM
https://reviews.llvm.org/D3
labath added a comment.
I am going to check this in to unbork the android bots. I'm happy to address
any additional feedback in a followup.
I'm also planning to come some unit tests for this class next week.
https://reviews.llvm.org/D32600
___
lld
labath updated this revision to Diff 97074.
labath added a comment.
Address review feedback.
https://reviews.llvm.org/D32600
Files:
include/lldb/Host/MainLoop.h
source/Host/common/MainLoop.cpp
Index: source/Host/common/MainLoop.cpp
==
labath added inline comments.
Comment at: source/Host/common/MainLoop.cpp:82
+ int queue_id;
+ std::vector events;
+ struct kevent event_list[4];
eugene wrote:
> here and below struct seems to be redundant
One of them holds the input events, and the other the
zturner added inline comments.
Comment at: source/Host/common/MainLoop.cpp:135
+
+template void MainLoop::RunImpl::ForEachReadFD(F &&f) {
+ assert(num_events >= 0);
Why do we need this function? Just have a function that returns an
`ArrayRef` and let the call
eugene added inline comments.
Comment at: source/Host/common/MainLoop.cpp:82
+ int queue_id;
+ std::vector events;
+ struct kevent event_list[4];
here and below struct seems to be redundant
https://reviews.llvm.org/D32600
_
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This looks like a nice improvement. There are some formatting inconsistencies,
can you run clang-format?
https://reviews.llvm.org/D32600
___
lldb-
labath created this revision.
Herald added a subscriber: srhines.
It turns out that even though ppoll is available on all the android
devices we support, it does not seem to be working properly on all of
them -- MainLoop just does a busy loop with ppoll returning EINTR and
not making any progress.
