[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

labath added a comment. I'm out of office this week. Could you hold until I get back? Hopefully we will see some development on the llvm/lld front in the meanwhile. Repository: rL LLVM https://reviews.llvm.org/D32597 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

clayborg added a comment. I would suggest adding Pavel and Tamas, or anyone that has contributed to DynamicLoaderPOSIXDYLD as this will affect them. Repository: rL LLVM https://reviews.llvm.org/D32597 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith added a subscriber: ruiu. scott.smith added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560 + struct loader { +DYLDRendezvous::iterator I; +ModuleSP m; +std::shared_future f; + }; + std::vector lo

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

zturner added a comment. https://reviews.llvm.org/D32826 Repository: rL LLVM https://reviews.llvm.org/D32597 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

zturner added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560 + struct loader { +DYLDRendezvous::iterator I; +ModuleSP m; +std::shared_future f; + }; + std::vector loaders(num_to_load); + llvm::ThreadPool lo

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560 + struct loader { +DYLDRendezvous::iterator I; +ModuleSP m; +std::shared_future f; + }; + std::vector loaders(num_to_load); + llvm::ThreadPoo

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

zturner added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560 + struct loader { +DYLDRendezvous::iterator I; +ModuleSP m; +std::shared_future f; + }; + std::vector loaders(num_to_load); + llvm::ThreadPool lo

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

zturner requested changes to this revision. zturner added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:530-560 + struct loader { +DYLDRendezvous::iterator I; +ModuleSP m; +

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith updated this revision to Diff 97695. scott.smith added a comment. update to use a private llvm::ThreadPool. I chose this over a 2nd global "TaskPool" because if the threads are going to be short lived, there isn't much point in having a global pool rather than a short-lived instanti

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith added a comment. 1. This change requires https://reviews.llvm.org/D32568 for correctness. 2. I think the use of std::thread should be replaced by a custom TaskPool, or else executables with thousands of shared libraries may have a problem. A separate TaskPool is necessary to prevent

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith created this revision. This change forks a thread for each shared library, so that as much work as possible can be done in parallel. Repository: rL LLVM https://reviews.llvm.org/D32597 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp source/Plugins/D