This revision was automatically updated to reflect the committed changes.
Closed by commit rL312430: FreeBSD: attach to pid from different cwd (authored
by emaste).
Changed prior to commit:
https://reviews.llvm.org/D32271?vs=113664&id=113669#toc
Repository:
rL LLVM
https://reviews.llvm.org/
emaste updated this revision to Diff 113664.
emaste added a comment.
correct variable
https://reviews.llvm.org/D32271
Files:
source/Host/freebsd/Host.cpp
Index: source/Host/freebsd/Host.cpp
===
--- source/Host/freebsd/Host.cpp
vbalu requested changes to this revision.
vbalu added a comment.
This revision now requires changes to proceed.
if (::sysctl(mib, 4, pathname, &len, NULL, 0) == 0)
"len" is not declared. Please change to "pathname_len".
https://reviews.llvm.org/D32271
__
emaste added a comment.
In https://reviews.llvm.org/D32271#759361, @dim wrote:
> As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME`
> has one drawback: if an executable file has multiple hard links, you will get
> just one of its filenames as the result. Since that f
krytarowski added a comment.
If we end up with hard links I think we should change them to symbolic ones.
This is a common policy in some open source distributions.
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.ll
dim added a comment.
As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME`
has one drawback: if an executable file has multiple hard links, you will get
just one of its filenames as the result. Since that filename is more or less
randomly chosen, it does *not* have to c
emaste added a comment.
Test case in https://reviews.llvm.org/D32522
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
In https://reviews.llvm.org/D32271#735354, @emaste wrote:
> In https://reviews.llvm.org/D32271#735098, @krytarowski wrote:
>
> > I have plan to revisit corresponding files in NetBSD and switch from kvm(3)
> > to sysctl(3). But this is lower priority than Process Plug
emaste added a comment.
In https://reviews.llvm.org/D32271#735098, @krytarowski wrote:
> I have plan to revisit corresponding files in NetBSD and switch from kvm(3)
> to sysctl(3). But this is lower priority than Process Plugin right now.
Thanks for the note. I wasn't aware that you had that p
krytarowski added a comment.
I have plan to revisit corresponding files in NetBSD and switch from kvm(3) to
sysctl(3). But this is lower priority than Process Plugin right now.
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-comm
vbalu accepted this revision.
vbalu added a comment.
This revision is now accepted and ready to land.
Fine. This will work. Thanks for the update.
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
emaste updated this revision to Diff 96334.
emaste added a comment.
Slightly simpler approach after early returns added in
https://reviews.llvm.org/rL301100
https://reviews.llvm.org/D32271
Files:
source/Host/freebsd/Host.cpp
Index: source/Host/freebsd/Host.cpp
=
emaste added a comment.
Sorry I've been away from LLDB for a bit, I will take a look at this soon.
Repository:
rL LLVM
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
13 matches
Mail list logo
