Re: [Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-19 Thread Davide Italiano via lldb-commits
On Wed, Apr 19, 2017 at 11:10 AM, Jim Ingham wrote: > We've had a couple of cases of "dead" code which turned out to be the > llvm.org side of generic behavior for which Swift was the only current > specific implementation. So while I agree, little single functions that > aren't used anywhere

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-19 Thread Davide Italiano via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300729: [Utility/StringLexer] Remove dead code. (authored by davide). Changed prior to commit: https://reviews.llvm.org/D32148?vs=95519&id=95788#toc Repository: rL LLVM https://reviews.llvm.org/D321

Re: [Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-19 Thread Jim Ingham via lldb-commits
We've had a couple of cases of "dead" code which turned out to be the llvm.org side of generic behavior for which Swift was the only current specific implementation. So while I agree, little single functions that aren't used anywhere are fine to cull, anything that looks like it might be the fo

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-19 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. Thanks! https://reviews.llvm.org/D32148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. No need to request review when removing dead code. https://reviews.llvm.org/D32148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D32148: [Utility/StringLexer] Remove dead code.

2017-04-17 Thread Davide Italiano via Phabricator via lldb-commits
davide created this revision. https://reviews.llvm.org/D32148 Files: include/lldb/Utility/StringLexer.h source/Utility/StringLexer.cpp Index: source/Utility/StringLexer.cpp === --- source/Utility/StringLexer.cpp +++ source/Util