This revision was automatically updated to reflect the committed changes.
Closed by commit rL300047: Fix libc++ vector data formatter (bug #32553)
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D31880?vs=94807&id=94951#toc
Repository:
rL LLVM
https://reviews.llvm.or
jasonmolenda added a comment.
This all looks good to me, thanks for doing this Pavel. Tamas asked in an
earlier comment, "The previous version of the data formatter was triggering for
std::vector> as well. Jason, do you know why was it the
case? Do we need that functionality because of a broke
labath updated this revision to Diff 94807.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D31880
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/TestDataFormatterLibcxxVBool.py
source/Plugins/Language/CPlusPlu
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibCxxVector.cpp:301-304
+ TypeImpl type = valobj_sp->GetTypeImpl();
+ if (!type.IsValid())
+return nullptr;
+ CompilerType compiler_type = type.GetCompiler
labath updated this revision to Diff 94667.
labath added a comment.
Remove the vector summary provider as well (picked up from Tamas's
version of the patch).
https://reviews.llvm.org/D31880
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/
tberghammer added a comment.
The previous version of the data formatter was triggering for
std::vector> as well. Jason, do you know why was it the
case? Do we need that functionality because of a broken compiler version or can
it be removed?
Note: I added a few comments about the data formatte
labath created this revision.
Herald added a reviewer: EricWF.
The iteration list through the available data formatters was undefined,
which meant that the vector formatter kicked in only in cases
where it happened to be queried before the general vector formatter. To
fix this, I merge the two dat
