[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-16 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski abandoned this revision. krytarowski added a comment. I will fix the original problem differently. Thanks for help! Repository: rL LLVM https://reviews.llvm.org/D31825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

Re: [Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-11 Thread Kamil Rytarowski via lldb-commits
Right, This patch happened to does not fully work for me (NetBSD-CORE@ switches were skipped), I will be back to it once I will get my current efforts done on watchpoints and fpr. Thank you for the initial scratch! On 11.04.2017 17:14, Zachary Turner wrote: > Just to be clear, this patch was onl

Re: [Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-11 Thread Zachary Turner via lldb-commits
Just to be clear, this patch was only intended to be a starting point. I didn't run the test suite or do anything other than verify that the core loaded. ArchSpec is a pretty core class so touching it in this manner is likely to have many side effects that you'll need to work out. Most likely so m

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-11 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. I might need some guidance to address the asserts appropriately in finite time. In general we set osabi to generic unix (value 0), and NetBSD core(5) files are distinguished only (or mostly) with "NetBSD-CORE*" notes. Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-11 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This makes all sorts of tests fail. Regardless of your platform you should at least be able to reproduce the following failures: FAIL: test_FPR_SSE (functionalities/postmortem/elf-

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Example core(5) file: http://netbsd.org/~kamil/lldb/top.core Generated with gcore(1), which snapshoted a running top(1) program. Repository: rL LLVM https://reviews.llvm.org/D31825 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski created this revision. krytarowski added a project: LLDB. This change has been authored by Zachary Turner. It fixes loading into the debugger core(5) files generated by NetBSD x86_64 v. 7.99.67. These core(5) files have the e_ident[EI_OSABI] property set to ELFOSABI_SYSV. It might ch

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. For the reference, I uploaded FreeBSD/amd64 and OpenBSD/i386 core(5) files: http://netbsd.org/~kamil/lldb/freebsd.10.3.release.p11-top.core.93102 http://netbsd.org/~kamil/lldb/openbsd.6.0-top.core Repository: rL LLVM https://reviews.llvm.org/D31825 ___

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Other BSDs work. Repository: rL LLVM https://reviews.llvm.org/D31825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

2017-04-10 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Hmm still wrong. Later in this code: // NetBSD per-thread information is stored in notes named // "NetBSD-CORE@nnn" so match on the initial part of the string. m_os = llvm::Triple::NetBSD; if (note.n_type == NETBSD::NT_PROCINFO) { ParseNetBSDProcInfo(*thr