This revision was automatically updated to reflect the committed changes.
Closed by commit rL308480: Expose hit count via SBBreakpointLocation. (authored
by brucem).
Repository:
rL LLVM
https://reviews.llvm.org/D31283
Files:
lldb/trunk/include/lldb/API/SBBreakpointLocation.h
lldb/trunk/p
brucem updated this revision to Diff 107297.
brucem added a comment.
Update per comments.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
packages/Python/lldbsuite/test
labath accepted this revision.
labath added a comment.
The test looks well written. I've added a couple of suggestions you can
consider including.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py:15
+
+my
brucem added a reviewer: labath.
brucem added a comment.
Pavel, since Jim was okay with this before apart from it not having a test,
want to take a quick look now? Thanks!
https://reviews.llvm.org/D31283
___
lldb-commits mailing list
lldb-commits@l
brucem updated this revision to Diff 107271.
brucem added a comment.
Add a test.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
packages/Python/lldbsuite/test/function
jingham added a comment.
BTW, other than the lack of a test, this is fine.
https://reviews.llvm.org/D31283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
If you are exposing this, could you write a test to make sure it stays correct?
I added a sample test that you can easily copy and modify in:
packages/Python/lldbsuite/test/sample
brucem created this revision.
SBBreakpointLocation exposed the ignore count, but didn't expose
the hit count. Both values were exposed by SBBreakpoint and
SBWatchpoint, so this makes things a bit more consistent.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
