labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Heh... I did not expect it would get this small, but ok. :)
Repository:
rL LLVM
https://reviews.llvm.org/D31138
___
lldb-commits mailing list
krytarowski updated this revision to Diff 92490.
krytarowski edited the summary of this revision.
krytarowski added a comment.
Cut down the unused functions from the Native Process NetBSD Plugin.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
Files:
source/Plugins/Process/CMakeLists.t
krytarowski updated this revision to Diff 92492.
krytarowski added a comment.
Style fix.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
Files:
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/NetBSD/CMakeLists.txt
source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
krytarowski added a comment.
In https://reviews.llvm.org/D31138#706216, @labath wrote:
> I like the idea of adding boilerplate first, so that we can than better focus
> on the important stuff later. However, I think you've have gone a bit too far
> with it -- you introduce a lot of functions I
labath added a comment.
I like the idea of adding boilerplate first, so that we can than better focus
on the important stuff later. However, I think you've have gone a bit too far
with it -- you introduce a lot of functions I am pretty sure will not be
necessary for your case, or that should be
krytarowski added a comment.
I have got a few local changes that conflict with
https://reviews.llvm.org/D31131, this is why I will hold on them unless
@kettenis does not intend to land his patch in the coming days.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
_
krytarowski created this revision.
krytarowski added a project: LLDB.
Herald added a subscriber: mgorny.
This is the base for introduction of further features to support Process
Tracing on NetBSD, in local and remote setup.
This code contains stubs of the needed functions. Their bodies will be a
