[Lldb-commits] [PATCH] D31079: Replace std::ofstream with llvm::raw_fd_ostream

2017-03-21 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL298375: Replace std::ofstream with llvm::raw_fd_ostream (authored by labath). Changed prior to commit: https://reviews.llvm.org/D31079?vs=92144&id=92484#toc Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [PATCH] D31079: Replace std::ofstream with llvm::raw_fd_ostream

2017-03-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D31079#703911, @zturner wrote: > In the places where you want to read from an `ifstream` and write to a > socket, you might consider using `llvm::sys::fs::copy_file`, declared in > `Support/FileSystem.h`. Currently it takes two paths, but all

[Lldb-commits] [PATCH] D31079: Replace std::ofstream with llvm::raw_fd_ostream

2017-03-17 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. In the places where you want to read from an `ifstream` and write to a socket, you might consider using `llvm::sys::fs::copy_file`, declared in `Support/FileSystem.h`. Currently it takes tw

[Lldb-commits] [PATCH] D31079: Replace std::ofstream with llvm::raw_fd_ostream

2017-03-17 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. ofstream does not handle paths with non-ascii characters correctly on windows, so I am switching these to llvm streams to fix that. Ideally I'd like to replace the two occurences of ifstream as well, but it's not clear to me what is the right replacement, as llvm int