This revision was automatically updated to reflect the committed changes.
Closed by commit rL299028: Centralize libc++ test skipping logic (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30984?vs=91878&id=93407#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30984
EricWF added a comment.
In https://reviews.llvm.org/D30984#713490, @labath wrote:
> In https://reviews.llvm.org/D30984#711806, @EricWF wrote:
>
> > I don't see anything wrong with this, but I only know libc++ and not LLDB.
>
>
> I'm not sure why you ended up here. I think you have too wide phabri
labath added a comment.
In https://reviews.llvm.org/D30984#711806, @EricWF wrote:
> I don't see anything wrong with this, but I only know libc++ and not LLDB.
I'm not sure why you ended up here. I think you have too wide phabricator
filter somewhere. :)
>
>
>> libc++'s atomic does not pla
EricWF added a comment.
I don't see anything wrong with this, but I only know libc++ and not LLDB.
> libc++'s atomic does not play well with gcc on linux
It should... Can you elaborate on this issue? I suspect this may be a libc++
bug.
https://reviews.llvm.org/D30984
labath added a comment.
Does anyone object to me landing this? I am going to be careful and wait for
the change to trickle through CI before submitting any followup changes.
https://reviews.llvm.org/D30984
___
lldb-commits mailing list
lldb-commits
labath created this revision.
Herald added a subscriber: srhines.
Herald added a reviewer: EricWF.
This aims to replace the different decorators we've had on each libc++
test with a single solution. Each libc++ will be assigned to the
"libc++" category and a single central piece of code will decid
