jroelofs closed this revision.
jroelofs added a comment.
r297626
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thank you.
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
jroelofs updated this revision to Diff 91566.
jroelofs added a comment.
It builds, so the code was dead anyway. Didn't re-run the tests.
https://reviews.llvm.org/D30844
Files:
include/lldb/Host/linux/HostThreadLinux.h
source/Host/linux/HostThreadLinux.cpp
Index: source/Host/linux/HostThre
labath added a comment.
In https://reviews.llvm.org/D30844#699265, @jroelofs wrote:
> > If you want to get your build working, I suggest you just remove the
> > setting code.
>
> @labath I have my local build working, but I don't want to carry local
> patches if possible.
Yes, that's what I m
jroelofs added a comment.
> If you want to get your build working, I suggest you just remove the setting
> code.
@labath I have my local build working, but I don't want to carry local patches
if possible. How about the original patch, which adds the glibc 2.12 check:
void HostThreadLinux::S
On 13 March 2017 at 12:35, Zachary Turner wrote:
> Can we just copy the non portable system call to this location and inline it
> here with appropriate glibc check so that we can still delete all that other
> obsolete code?
>
That makes sense. I think that code belongs in NativeThreadLinux
anyway
Can we just copy the non portable system call to this location and inline
it here with appropriate glibc check so that we can still delete all that
other obsolete code?
On Mon, Mar 13, 2017 at 4:28 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath requested changes to thi
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
We need the getter code to get the name of the threads of the process we are
debugging, so this cannot go away. It also probably does not make sense to move
this code into llvm, as i
labath is in Europe, so he will probably not see this until tonight.
On Fri, Mar 10, 2017 at 3:31 PM Jonathan Roelofs via Phabricator <
revi...@reviews.llvm.org> wrote:
> jroelofs added a comment.
>
> In https://reviews.llvm.org/D30844#698294, @zturner wrote:
>
> > The test suite is full of flaki
jroelofs added a comment.
In https://reviews.llvm.org/D30844#698294, @zturner wrote:
> The test suite is full of flakiness, but as long as it's the same before and
> after your change, it doesn't seem like anything is broken.
Results are pretty much the same, with 1 or 2 twinkling tests (could
jroelofs added a subscriber: labath.
jroelofs added a comment.
@labath thoughts?
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
labath@ will need to comment on this. I wasn't aware that we were getting the
thread name anywhere else. Im not sure if this code is even important, but
hopefully it is not.
The test suite is full of flakiness, but as long as it's the same before and
after your chang
jroelofs updated this revision to Diff 91419.
jroelofs added a comment.
Herald added a subscriber: emaste.
Built successfully on linux (lots of tests fail, not sure if that's expected or
not?). I don't have a FreeBSD machine, but it looks "obviously" the same.
https://reviews.llvm.org/D30844
F
jroelofs added a comment.
erm, nevermind, I misread.
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Oh wait, there's nothing else in those files Usually someone on the Apple
team picks up the slack when changes are required to the Xcode project. If you
use Xcode, you're welcome to remove them yourself.
(Goes without saying, but make sure the build still succeeds
zturner added a comment.
I don't think you need to delete the entire files. Just the `SetName` function.
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
jroelofs added a comment.
looks like lldb.xcodeproj refers to the files which I'll be deleting... do I
need to worry about that?
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
jroelofs added a comment.
sure
https://reviews.llvm.org/D30844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
It looks like I just forgot to remove those functions. All the callers have
been updated to use the llvm method. Can you just delete this method (and the
one in `HostThreadFreeBSD`?
https://reviews.llvm.org/D30844
___
ll
jroelofs added a comment.
Yeah, I'm on tip of trunk as of a few minutes ago.
`llvm::set_thread_name()` exists, but it doesn't take a thread parameter like
this one does (no idea if that's (still?) used or not in lldb).
https://reviews.llvm.org/D30844
zturner added a comment.
Hmm.. I thought this code was gone? Are you at tip of trunk? If so then I
must be crazy. I added `llvm::set_thread_name()` which already handles all
this correctly, and I thought I converted all of LLDB's clients over to using
the LLVM function.
https://reviews.ll
jroelofs created this revision.
Herald added a subscriber: srhines.
Alternatively, I could teach llvm:set_thread_name() how to take a thread
parameter, and use that here instead.
https://reviews.llvm.org/D30844
Files:
source/Host/linux/HostThreadLinux.cpp
Index: source/Host/linux/HostThrea
22 matches
Mail list logo
