This revision was automatically updated to reflect the committed changes.
Closed by commit rL297598: Use LLVM for file / directory enumeration. (authored
by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30807?vs=91260&id=91513#toc
Repository:
rL LLVM
https://reviews.llvm.org/
I can see both of them making sense, but I would actually prefer the
new behavior you inadvertently introduced. I've looked at the callers
and it seems no user sets find_directories to false, so I guess it's
fine to change the behavior, if we want to.
On 10 March 2017 at 14:08, Zachary Turner wro
You're right, I didn't notice that. But since you mention it, surely that
had to have been a bug in the original implementation right? That flag
isn't intended to be a synonym for "non recursive iteration ", because
that's what the Next enumeration value is for. The algorithm would
intentionally le
labath added a comment.
Comment at: lldb/source/Host/common/FileSpec.cpp:786
+ continue;
+if (!find_directories && fs::is_directory(Status))
+ continue;
This looks like it changes behavior. Previously, if `find_directories` was
false this functi
zturner created this revision.
`FileSpec::EnumerateDirectory` has a bunch of platform-specific gunk in it for
posix and non-posix platforms. We can get rid of all this by using LLVM's
easy-to-use directory iterators.
Ideally I would like to just remove this entire `EnumerateDirectory` function
