This revision was automatically updated to reflect the committed changes.
Closed by commit rL297300: Resubmit FileSystem changes. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D30698?vs=90905&id=91044#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30698
Files:
Yes it was a debug build
On Wed, Mar 8, 2017 at 2:45 AM Pavel Labath wrote:
> I've tried it out not and it works -- I think it's good to go then.
>
> The unit tests, was that a debug build by any chance? I think we are
> missing some dependency there which shows up only on debug builds, but
> I h
I've tried it out not and it works -- I think it's good to go then.
The unit tests, was that a debug build by any chance? I think we are
missing some dependency there which shows up only on debug builds, but
I haven't dug into that yet.
On 7 March 2017 at 22:28, Zachary Turner wrote:
> I can run
I can run build TargetTests though (I guess it doesn't depend on editline),
and that one passes.
On Tue, Mar 7, 2017 at 2:26 PM Zachary Turner wrote:
> =
> Issue Details
> =
> UNEXPECTED SUCCESS: test_and_run_command_dwarf
> (lang/c/register_variables/TestRegisterVariable
=
Issue Details
=
UNEXPECTED SUCCESS: test_and_run_command_dwarf
(lang/c/register_variables/TestRegisterVariables.py)
UNEXPECTED SUCCESS: test_and_run_command_dwo
(lang/c/register_variables/TestRegisterVariables.py)
UNEXPECTED SUCCESS: test_dwarf
(functionalities/thread/exit
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
OK, let's give this another shot. (I haven't tried it on linux yet, so if you
haven't either then let's wait until tomorrow, or maybe @eugene could try it
out (?)). I don't think we need to be
zturner updated this revision to Diff 90905.
zturner added a comment.
Fixed all the outstanding issues. I simplified the logic in `ModuleCache`, but
I think it makes more sense this way, and the unit tests still pass. If we
really care about the case where we want to create a directory on top
zturner added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197
+ namespace fs = llvm::sys::fs;
+ if (fs::get_file_type(local_path_spec.GetPath(), false) !=
+ fs::file_type::symlink_file)
labath wrote:
> labath wrote
labath added a comment.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197
+ namespace fs = llvm::sys::fs;
+ if (fs::get_file_type(local_path_spec.GetPath(), false) !=
+ fs::file_type::symlink_file)
labath wrote:
> This still break
labath added a comment.
Unfortunately, this does not seem to help. I'll try to debug today if I can
find the time.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197
+ namespace fs = llvm::sys::fs;
+ if (fs::get_file_type(local_path_spec.GetPath(), fals
zturner created this revision.
Herald added a subscriber: emaste.
This was broken due to LLVM's stat code following symlinks. I've added an
option on the LLVM side to not follow symlinks and updated this patch to use it
everywhere possible. The cases I couldn't get were where LLDB calls
`is_d
11 matches
Mail list logo
