This revision was automatically updated to reflect the committed changes.
Closed by commit rL296592: Modernize Enable/DisableLogChannel interface a bit
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30402?vs=9&id=90132#toc
Repository:
rL LLVM
https://reviews.ll
Lgtm
On Tue, Feb 28, 2017 at 3:08 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath updated this revision to Diff 9.
> labath added a comment.
>
> rebase on top of tree
>
>
> https://reviews.llvm.org/D30402
>
> Files:
> include/lldb/Core/Debugger.h
> include/lldb/
labath updated this revision to Diff 9.
labath added a comment.
rebase on top of tree
https://reviews.llvm.org/D30402
Files:
include/lldb/Core/Debugger.h
include/lldb/Core/Log.h
include/lldb/Interpreter/Args.h
source/API/SBDebugger.cpp
source/Commands/CommandObjectLog.cpp
source
labath updated this revision to Diff 89996.
labath marked 3 inline comments as done.
labath added a comment.
Address review comments
https://reviews.llvm.org/D30402
Files:
include/lldb/Core/Debugger.h
include/lldb/Core/Log.h
include/lldb/Interpreter/Args.h
source/API/SBDebugger.cpp
so
labath added a comment.
Comment at: include/lldb/Interpreter/Args.h:196-197
+ llvm::ArrayRef GetArgumentArrayRef() const {
+return {static_cast(m_argv.data()),
+m_argv.size() - 1};
+ }
zturner wrote:
> can this be written `return makeArrayRef
zturner added inline comments.
Comment at: include/lldb/Interpreter/Args.h:196-197
+ llvm::ArrayRef GetArgumentArrayRef() const {
+return {static_cast(m_argv.data()),
+m_argv.size() - 1};
+ }
can this be written `return makeArrayRef(m_argv).drop
labath created this revision.
Use StringRef and ArrayRef where possible. This adds an accessor to the
Args class to get a view of the arguments as ArrayRef.
https://reviews.llvm.org/D30402
Files:
include/lldb/Core/Debugger.h
include/lldb/Core/Log.h
include/lldb/Interpreter/Args.h
source
