Indeed it should, but unfortunately this is a hand maintained project, and
I don't have a Mac.
Usually in these cases the first person to notice the Xcode project is
broken just submits a fix for it
On Tue, Feb 14, 2017 at 11:27 PM Boris Ulasevich via Phabricator <
revi...@reviews.llvm.org> wrote:
boris.ulasevich added a comment.
FYI.
After r295088 commit Xcode project fails with "no such file or directory:
'/Users/boris/ws/lldb/lldb/source/Utility/ModuleCache.cpp'" message.
I think lldb.xcodeproj/project.pbxproj should be updated.
Repository:
rL LLVM
https://reviews.llvm.org/D29909
labath accepted this revision.
labath added a comment.
looks good
https://reviews.llvm.org/D29909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In https://reviews.llvm.org/D29909#675644, @krytarowski wrote:
> In https://reviews.llvm.org/D29909#675621, @zturner wrote:
>
> > `git log --follow` seems to understand. Is that sufficient to guarantee
> > that it will be retained on the SVN side?
>
>
> On SVN there is
krytarowski added a comment.
In https://reviews.llvm.org/D29909#675621, @zturner wrote:
> `git log --follow` seems to understand. Is that sufficient to guarantee that
> it will be retained on the SVN side?
On SVN there is need to explicitly rename files to retain history. (`svn mv old
new` o
clayborg added a comment.
I don't know enough to say for sure. Go ahead and try it with this patch as the
files are pretty simple and losing the history wouldn't be too bad on these
files. If it fails to have history, then you should use an SVN workflow for any
future moves.
https://reviews.l
zturner added a comment.
`git log --follow` seems to understand. Is that sufficient to guarantee that
it will be retained on the SVN side?
D:\src\llvm-mono>git log --follow lldb/source/Target/ModuleCache.cpp
commit 07bf36c627f3a4304dbb8ea3f8347110a025bd93
Author: Zachary Turner
Date:
zturner added a comment.
I'm not sure, it's a bit of black magic :-/ I use git with mono-repo, and
there is a bunch of magic that happens at the git-svn layer. When I run `git
status` it shows me that the files are renames / moves, so I hope that means
that it preserves the history when it go
clayborg added a comment.
Hopefully we are maintaining the SVN history for these files? Hard to tell from
the patch.
https://reviews.llvm.org/D29909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
https://reviews.llvm.org/D29909
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
zturner created this revision.
Herald added a subscriber: mgorny.
This completely removes the dependency from `lldbUtility` -> `lldbCore` and
`lldbTarget`. This was done with the following restructure:
1. `ProcessStructReader`: `Utility` -> `Target`
2. `ModuleCache`: `Utility` -> `Target`
3. `R
11 matches
Mail list logo
