This revision was automatically updated to reflect the committed changes.
Closed by commit rL293910: Unify PlatformPOSIX::ResolveExecutable (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D29406?vs=86672&id=86846#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2940
krytarowski added a comment.
It looks good.
https://reviews.llvm.org/D29406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:163
+ // Resolve any executable within a bundle on MacOSX
+ Host::ResolveExecutableInBundle(resolved_module_spec.GetFileSpec());
+
This is the bit that was only pr
labath created this revision.
various platforms very using nearly identical code for this method. As far as I
can tell there was nothing platform-specific about the differences, but rather
it looked like it was caused by tiny tweaks being made to individual copies
without affecting the overall fun
